Messages in this thread | ![/](/images/icornerl.gif) | | From | "Antonino A. Daplas" <> | Subject | Re: [Linux-fbdev-devel] Re: [2.6 patch] drivers/video/: misc cleanups | Date | Tue, 23 Nov 2004 04:46:47 +0800 |
| |
On Monday 22 November 2004 17:43, Geert Uytterhoeven wrote: > On Mon, 22 Nov 2004, Antonino A. Daplas wrote: > > On Sunday 21 November 2004 23:58, Adrian Bunk wrote: > > > On Sun, Nov 21, 2004 at 04:37:02PM +0100, Adrian Bunk wrote: > > > > The patch below does the following cleanups under drivers/video/ : > > > > - make some needlessly global code static > > > > - the following was needlessly EXPORT_SYMBOL'ed: > > > > - fbcon.c: fb_con > > > > - mdacon.c: fb_blank > > > > - fbmon.c: get_EDID_from_firmware (completely unused) > > > >... > > > > > > I forgot one thing: > > > > > > Please review my global_mode_option removal in modedb.c . > > > > > > It was always NULL and I'd say the only usage was wrong (although it > > > had no practical effect). > > > > Should be ok to remove it. I only see fb_find_mode using it, and as > > you've concluded, usage is not very clear. > > > > BTW: The global_mode_option, previously, is filled up when no driver is > > specified in the boot options, such as "video=1024x768@60". But this was > > removed during the fb initialization cleanup. > > What a pity... It allowed people to not have to care about the name of > their graphics driver(s)... >
The absence of the driver name array will make it a bit difficult to differentiate between options passed specifically to drivers vs the global mode option.
We can bring global_mode_option back. Since driver names always have a terminating "fb", we can search for the "fb:" substring and if not found, then it's a global_mode_option.
Is that okay?
Tony
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| ![\](/images/icornerr.gif) |