Messages in this thread Patch in this message | | | Date | Mon, 22 Nov 2004 17:30:35 +0100 | From | Stelian Pop <> | Subject | Re: [PATCH] usb-storage should enable scsi disk in Kconfig |
| |
On Mon, Nov 22, 2004 at 08:01:30AM -0800, Randy.Dunlap wrote:
> >>>>Maybe we should add, just below the 'USB storage' Kconfig option another > >>>>one, let's say 'SCSI disk based USB storage support', which > >>>>documentation > >>>>would talk about 'usb keys, memory stick readers, USB floppy drives > >>>>etc', > >>>>which should just be a dummy option selecting BLK_DEV_SD ? > > > > > >>Until 'suggests' is available, does this help any? > >>It's tough getting people to read Help messages though. > >> > >>Add comment/NOTE that USB_STORAGE probably needs BLK_DEV_SD also. > >>Add a few device types to help text and reformat it. > > > > > >Isn't my above suggestion even better ? A separate config option > >is much more visible IMHO... > > Sounds good, as long as we don't mind the same option being > settable in multiple places. Did you submit a patch?
Nope, I was waiting for the discussion to settle.
But here it is:
===== drivers/usb/storage/Kconfig 1.9 vs edited ===== --- 1.9/drivers/usb/storage/Kconfig 2004-06-13 17:24:10 +02:00 +++ edited/drivers/usb/storage/Kconfig 2004-11-22 17:27:43 +01:00 @@ -45,6 +45,16 @@ If you say N here, the kernel will assume that all disk-like USB devices are write-enabled. +config USB_STORAGE_SD + bool "USB Mass Storage SCSI-like disks" + depends on USB_STORAGE + select BLK_DEV_SD + help + Say Y here if you want to enable support for SCSI-like USB + connected disks. These are the most used USB Mass Storage + devices, and include USB keys, USB floppy drives, most USB + flash memory readers, some USB photo cameras etc. + config USB_STORAGE_DATAFAB bool "Datafab Compact Flash Reader support (EXPERIMENTAL)" depends on USB_STORAGE && EXPERIMENTAL -- Stelian Pop <stelian@popies.net> - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |