Messages in this thread | | | From | Rolf Eike Beer <> | Subject | Re: [PATCH] sr module_param conversion | Date | Sun, 21 Nov 2004 12:13:38 +0100 |
| |
Jan Dittmer wrote: > module_param conversion for SCSI cdrom driver > > Signed-off-by: Jan Dittmer <jdittmer@ppp0.net>
> diff -Nru a/drivers/scsi/sr_ioctl.c b/drivers/scsi/sr_ioctl.c > --- a/drivers/scsi/sr_ioctl.c 2004-11-14 00:36:56 +01:00 > +++ b/drivers/scsi/sr_ioctl.c 2004-11-14 00:36:56 +01:00 > @@ -29,6 +29,9 @@ > * It is off by default and can be turned on with this module parameter */ > static int xa_test = 0; > > +module_param(xa_test, int, S_IRUGO | S_IWUSR); > + > +
I think it should be "bool" instead of "int". And one newline should be enough for everyone.
You should CC linux-scsi@vger.kernel.org and James Bottomley <James.Bottomley@steeleye.com> to get this applied.
Eike - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |