[lkml]   [2004]   [Nov]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH] dss1_divert ISDN module compile fix for kernel
    On Wed, 17 Nov 2004 19:52:54 +0100, Steffen A. Mork
    <> wrote:
    > Dear Linus and Bartlomiej,
    > >>when I switched my installation from kernel 2.4 to 2.6 I
    > >>recognized that the ISDN module dss1_divert was marked
    > >>incompilable (config option CONFIG_CLEAN_COMPILE must
    > >>be turned off). The compile problem was the obsolete using
    > >>of kernel 2.4 critical sections. I replaced the cli() stuff
    > >>with spinlocks as explained in the Documentation/spinlocks.txt
    > >>file. After that the module compiles and runs as expected.
    > >
    > >
    > > This looks wrong, you are using many private spinlocks instead
    > > of one global spinlock.

    Moreover, you must make sure that there is no other code (ie. in generic
    ISDN code) doing cli() stuff on objects that you are protecting by a spinlock
    etc., I've checked divert driver and it looks OK.

    > OK, thank you. I went into the copy/paste trap. I corrected the patch to
    > a global spinlock and tested it successfully.


    > The corrected patch is applied to kernel and should work for
    > all 2.6 versions. You may also download the patch via http, too:
    > Signed-off-by: Steffen A. Mork <>

    Please do "interdiff" between the old and the new patch
    and send it to Linus (he has already merged the old patch).

    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to
    More majordomo info at
    Please read the FAQ at

     \ /
      Last update: 2005-03-22 14:08    [W:0.021 / U:30.448 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site