lkml.org 
[lkml]   [2004]   [Nov]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectOne more get_task_comm()

Looking at get_task_comm patch:
http://linus.bkbits.net:8080/linux-2.5/patch@1.1803.144.3

There is one other place where task->comm is accessed
outside current. There are two issues. The code is
trying to copy to temp space without task_lock. It is not
using temp space for actual user copy.

--- arch/mips/kernel/sysirix.c.saved Wed Nov 17 13:18:50 2004
+++ arch/mips/kernel/sysirix.c Wed Nov 17 13:29:11 2004
@@ -282,7 +282,7 @@
int pid = (int) regs->regs[base + 5];
char *buf = (char *) regs->regs[base + 6];
struct task_struct *p;
- char comm[16];
+ char comm[sizeof(current->comm)];

retval = verify_area(VERIFY_WRITE, buf, 16);
if (retval)
@@ -294,11 +294,11 @@
retval = -ESRCH;
break;
}
- memcpy(comm, p->comm, 16);
+ get_task_comm(comm, p);
read_unlock(&tasklist_lock);

/* XXX Need to check sizes. */
- copy_to_user(buf, p->comm, 16);
+ copy_to_user(buf, comm, 16);
retval = 0;
break;
}
Related questions:

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:08    [W:0.052 / U:0.048 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site