Messages in this thread Patch in this message | | | Date | Wed, 17 Nov 2004 20:51:48 +0100 | From | Colin Leroy <> | Subject | Re: [PATCH] Switch therm_adt746x to new module_param |
| |
On 17 Nov 2004 at 10h11, Randy.Dunlap wrote:
Hi,
> The last parameter here (64) is not an init. value nor a > suggested parameter value. > It's a permission for an entry in /sys (sysfs). > 0 means not visible there. > If it should be visible there, use something like > 0444 (read-only by anyone) or 0644 (read-write by root).
Uh, thank you :) Updated patch follows:
Signed-off-by: Colin Leroy <colin@colino.net> --- a/drivers/macintosh/therm_adt746x.c 2004-11-17 19:26:16.908413504 +0100 +++ b/drivers/macintosh/therm_adt746x.c 2004-11-17 19:28:01.193559752 +0100 @@ -23,6 +23,8 @@ #include <linux/smp_lock.h> #include <linux/wait.h> #include <linux/suspend.h> +#include <linux/kthread.h> +#include <linux/moduleparam.h> #include <asm/prom.h> #include <asm/machdep.h> @@ -30,7 +32,6 @@ #include <asm/system.h> #include <asm/sections.h> #include <asm/of_device.h> -#include <linux/kthread.h> #undef DEBUG @@ -56,11 +57,11 @@ "Powerbook G4 Alu"); MODULE_LICENSE("GPL"); -MODULE_PARM(limit_adjust,"i"); +module_param(limit_adjust, int, 0644); MODULE_PARM_DESC(limit_adjust,"Adjust maximum temperatures (50 cpu, 70 gpu) " "by N degrees."); -MODULE_PARM(fan_speed,"i"); +module_param(fan_speed, int, 0644); MODULE_PARM_DESC(fan_speed,"Specify starting fan speed (0-255) " "(default 64)"); - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |