Messages in this thread | | | Date | Tue, 16 Nov 2004 06:24:46 -0800 | From | William Lee Irwin III <> | Subject | Re: [patch 4/4] Cleanup file_count usage: Avoid file_count usage for hugetlb nattach reporting |
| |
On Tue, Nov 16, 2004 at 07:41:25PM +0530, Ravikiran G Thirumalai wrote: > The file_count macro usage to get the number of attaches to a hugetlb > sysv style shared memory segment, seems to work although it looks bogus > on the first look. But we want to get rid of file_count macros and > reads to struct file.f_count. This patch cleans up the file_count usage > for shm hugetlb attaches. The nattch counter is maintained on the same > lines as in regular sysv shared memory segments. The file_operations for the > struct file of the shared memory hugetlb segment now is different from the > hugetlbfs specific f_ops. > Patch has been tested with some userspace testcases > Signed-off-by: Ravikiran Thirumalai <kiran@in.ibm.com>
I'm generally in favor of getting rid of the ->f_count twiddling from hugetlb, though I've not reviewed this closely.
-- wli - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |