lkml.org 
[lkml]   [2004]   [Nov]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] [Request for inclusion] Filesystem in Userspace
From
Date
On Tue, 2004-11-16 at 10:40 +0100, Miklos Szeredi wrote:
> > somehow I find dropping the lock and then doing a list_del() without
> > any kind of verification very suspicious.
>
> list_del() is done with the lock held. Look closely.

yes but how do you know the entry is still on the list and valid ?
you dropped the lock. A normal code pattern is that you then HAVE
to revalidate the assumptions which you guard by that lock.
If there are no such assumptions... then you didn't need the lock.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:08    [W:0.315 / U:0.720 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site