Messages in this thread | | | Subject | Re: [PATCH] [Request for inclusion] Filesystem in Userspace | From | Arjan van de Ven <> | Date | Tue, 16 Nov 2004 10:46:13 +0100 |
| |
On Tue, 2004-11-16 at 10:40 +0100, Miklos Szeredi wrote: > > somehow I find dropping the lock and then doing a list_del() without > > any kind of verification very suspicious. > > list_del() is done with the lock held. Look closely.
yes but how do you know the entry is still on the list and valid ? you dropped the lock. A normal code pattern is that you then HAVE to revalidate the assumptions which you guard by that lock. If there are no such assumptions... then you didn't need the lock.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |