Messages in this thread | | | Date | Mon, 15 Nov 2004 13:54:24 -0800 | From | "Randy.Dunlap" <> | Subject | Re: [PATCH] Regparm for x86 machine check handlers |
| |
Linus Torvalds wrote: > > On Mon, 15 Nov 2004, Brian Gerst wrote: > >>The patch to change traps and interrupts to the fastcall convention >>missed the machine check handlers. > > > Thanks, that was silly. > > Anybody want to write a script that verifies that the only remaining > "asmlinkage" entries are of the type "sys_xxxx()"?
Is part of the problem definition missing here? or I missed it?
E.g., printk() and vprint() are asmlinkage but not sys_xyz()... but I have a suspicion that they are OK.
> "grep" shows that there's a number of incorrect ones left, but most of > them seem to take no arguments, so ir doesn't matter. And there's the FP > emulation stuff, which really -does- use the old interfaces.
so ignore the FP emulation, ignore functions with no arguments, right?
and omit "asmlinkage.*sys_xyz". that leaves a handful of functions which are <asm>, like:
acpi_status asmlinkage acpi_enter_sleep_state(u8 sleep_state); csum_partial(), csum_partial_copy_generic(), schedule_tail(), aes_enc_blk(), aes_dec_blk().
I don't see others than need to be fixed, but a script would be a safer way to check, so I'm trying to nail down the requirements ... and what tool to use, like is there already a PERL [or python or xyz] script that parses C, or would you *coff* recommend sparse?
-- ~Randy - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |