Messages in this thread | | | Date | Sat, 13 Nov 2004 20:43:34 -0800 (PST) | From | Linus Torvalds <> | Subject | Re: Oops in 2.6.10-rc1 (almost solved) |
| |
On Sat, 13 Nov 2004, Matt Domsch wrote: > > Not ready for Linus yet
Indeed. Please don't use pushfl/popfl to save the carry flag. There are tons of better ways.
For example, use "lea" instead of "add" to not write the flags (and add a comment). Or save the carry flag in a register with
sbb %bx,%bx
ant test %bx later. Or any of a million other _standard_ ways to handle this problem.
Linus - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |