Messages in this thread Patch in this message | | | Date | Thu, 11 Nov 2004 16:46:56 +0100 | From | Adrian Bunk <> | Subject | Re: [ACPI] [2.6 patch] drivers/acpi: #ifdef unused functions away |
| |
On Thu, Nov 11, 2004 at 03:40:17PM +0000, Matthew Wilcox wrote: > On Thu, Nov 11, 2004 at 04:36:50PM +0100, Adrian Bunk wrote: > > On Thu, Nov 11, 2004 at 03:17:27PM +0000, Matthew Wilcox wrote: > > > On Wed, Nov 10, 2004 at 02:21:34AM +0100, Adrian Bunk wrote: > > > > This patch only #ifdef's completely unused code away - it does not make > > > > the many global functions only used inside the file they are defined in > > > > static. > > > > > > It also ifdefs out the acpi_install_gpe_handler and acpi_remove_gpe_handler > > > calls I use in the driver I posted on Sunday. Please fix this. > > > > ???? > > > > My patch doesn't #ifdef these functions away. > > Sorry, acpi_remove_gpe_block, not acpi_remove_gpe_handler: > > @@ -383,6 +398,7 @@ > acpi_status > acpi_remove_gpe_block ( > acpi_handle gpe_device); > +#endif /* ACPI_FUTURE_USAGE */
I didn't saw your patch on linux-kernel, and although Len has said that he'd apply my patches I have yet to hear an answer indicating either problems in my patches or that he'd applied them.
Did Len already integrate your driver into his tree?
If yes, I will correct the acpi_remove_gpe_block case (it's only this one function?) as soon as his tree appears in the next -mm.
cu Adrian
-- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |