lkml.org 
[lkml]   [2004]   [Nov]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] fix platform_rename_gsi related ia32 build breakage


    On Wed, 10 Nov 2004, Arnaldo Carvalho de Melo wrote:
    >
    > This one compiles and links OK.

    Including when CONFIG_ACPI_BOOT is set? Does it see the prototype then?
    Looks like <asm/acpi.h> should be included, but I assume it gets included
    some other way?

    Quite frankly, I think the whole thing is broken. #ifdef's inside code is
    _evil_, and "platform_rename_gsi()" doesn't make sense as a name. I'll
    apply your patch, but quite frankly, I think the ACPI layer is doing crap.

    Len, can you please use a more descriptive name, and have it be always
    defined (make it an inline function that just becomes a no-op or
    something).

    Linus
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2009-11-18 23:46    [W:0.022 / U:182.916 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site