Messages in this thread Patch in this message | | | Date | Fri, 8 Oct 2004 16:12:05 -0700 | From | Chris Wright <> | Subject | Re: [PATCH] Realtime LSM |
| |
* Lee Revell (rlrevell@joe-job.com) wrote: > On Fri, 2004-10-08 at 18:24, Chris Wright wrote: > > (relative to last one) > > > > use in_group_p > > > > Thanks! These make the patch even smaller and more comprehensible. > Does this cover all the issues with the patch as I posted it?
The last bit is removing sysctls. It'll take a bit more effort, as we need a touch of infrastructure for it. I'm working on that now. Here's a couple really minor ones.
- make realtime_bprm_set_security static - don't mark exit_security __exit, it's called from an __init function
thanks, -chris -- Linux Security Modules http://lsm.immunix.org http://lsm.bkbits.net
--- security/realtime.c 2004-10-08 16:10:52.080357656 -0700 +++ security/realtime.c~in_group 2004-10-08 16:02:05.932344312 -0700 @@ -71,7 +71,7 @@ return in_group_p(gid); } -static int realtime_bprm_set_security(struct linux_binprm *bprm) +int realtime_bprm_set_security(struct linux_binprm *bprm) { cap_bprm_set_security(bprm); @@ -170,7 +170,7 @@ static int secondary; /* flag to keep track of how we were registered */ -static void exit_security(void) +static void __exit exit_security(void) { /* remove ourselves from the security framework */ if (secondary) { - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |