lkml.org 
[lkml]   [2004]   [Oct]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH] QStor SATA/RAID driver for 2.6.9-rc3
    From
    Date
    On Thu, 2004-10-07 at 16:15, Christoph Hellwig wrote:
    > - please use the kernel/kthread.c interface for your kernel thread

    Actually, the driver has no need for a thread at all. Since you're
    simply using it to fire hotplug events, use schedule_work instead.

    I also noticed the following in a lightening review:

    - Kill these constructs:
    + /* scsi_done expects to be called while locked */
    + if (!in_interrupt())
    + spin_lock_irqsave(uhba->lock, flags);

    scsi_done() doesn't require a lock

    - Your emulated commands assume they're non-sg and issued through the
    kernel (i.e. you don't kmap and you don't do SG). This will blow up on
    the first inquiry submitted via SG_IO for instance.

    I'm sure there are others, but I don't have time to do a thorough review
    at the moment.

    James


    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 14:06    [W:6.348 / U:0.708 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site