Messages in this thread | | | Subject | Re: [PATCH] Kill a sparse warning in binfmt_elf.c | From | Valdis.Kletnieks@vt ... | Date | Thu, 07 Oct 2004 15:27:26 -0400 |
| |
On Thu, 07 Oct 2004 12:16:23 PDT, "David S. Miller" said:
> The caller's aren't, that is the point. They run dump_write() > with set_fs(KERNEL_DS), which allows kernel pointers to be treated > as user ones in system call handling paths, which is why the cast > is needed somewhere.
Right - and my point is that putting one cast way down at the bottom to quiet a warning doesn't do much good - the cast should be pushed up to as close to that set_fs() as feasible. Otherwise if some other, new, caller surfaces and bogusly passes something *else* in that void * pointer, it gets a lot harder for sparse and similar to do their jobs.
[unhandled content-type:application/pgp-signature] | |