lkml.org 
[lkml]   [2004]   [Oct]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: Raylink/WebGear testing - ray_cs.c iomem bug?


On Wed, 6 Oct 2004, David S. Miller wrote:
>
> In the spot where this occurs, it adds both CCS_BASE and
> 'rcsindex' to the sram base, and only when rcsindex >= NUMBER_OF_CCS.
>
> NUMBER_OF_CCS is 64, and the difference between CCS_BASE and RCS_BASE
> is 0x400 so this really doesn't account for anything.

It does, though: as I noted in my second mail (after trying to figure it
out some more) the size of both ccs and rcs is 16 bytes, so when you
offset by 64, so the difference between RCS_BASE and CCS_BASE ends up
being exactly "NUMBER_OF_CCS*sizeof(struct ccs/rcs)", which explains how
the base is the same, and the _index_ ends up being the one that selects
between the two.

> I can't see how you've changed the behavior, so it should work as well
> as it did before your changes.

Agreed. I've only removed a few casts, and cleaned up some of the
accesses, so it _should_ work the way it did before.

Of course, I _should_ be handsome, so things clearly don't always work out
the way they should. Testing would still be appreciated.

Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2009-11-18 23:46    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site