Messages in this thread |  | | | From | Arnd Bergmann <> | | Subject | Re: proper way to annotate kernel use of sys_xxx? | | Date | Tue, 5 Oct 2004 10:32:33 +0200 | |
On Dienstag, 5. Oktober 2004 07:28, Roland Dreier wrote:
> This is an abuse of sys_open(), but we know it's OK. Is the right way
> to shut up sparse to just change it to:
>
> fd = sys_open((const char __user *) path, 0, 0);
>
No, that's wrong, see
http://marc.theaimsgroup.com/?l=linux-kernel&m=108697882525067 ;-)
In this case, you can easily convert the calls to use
filp_open/vfs_read/filp_close, though I'm not sure if that's
the correct solution either.
Arnd <><
[unhandled content-type:application/pgp-signature] |  |