Messages in this thread Patch in this message | | | Date | Tue, 5 Oct 2004 11:01:12 -0700 | From | Keshavamurthy Anil S <> | Subject | Re: [PATCH 2.6][resend] Add DEVPATH env variable to hotplug helper call |
| |
On Tue, Oct 05, 2004 at 10:47:44AM -0700, Andrew Morton wrote: > Keshavamurthy Anil S <anil.s.keshavamurthy@intel.com> wrote: > > > > On Tue, Oct 05, 2004 at 10:18:23AM -0700, Andrew Morton wrote: > > > Keshavamurthy Anil S <anil.s.keshavamurthy@intel.com> wrote: > > > > > > > > Here is what I have come up with(please take a look at this patch). > > > > I was successfully able to get rid of cpu_run_sbin_hotplug() function, but > > > > when I call kobject_hotplug() function, it is finding > > > > top_kobj->kset->hotplug_ops set to NULL and hence returns without calling > > > > call_usermodehelper(). Not sure if this is a bug in kobject_hotplug(), > > > > I feel kobject_hotplug() function should continue even if > > > > top_kobj->kset-hotplug_ops is NULL. > > > > > > Yes, it doesn't seem necessary. We could give cpu_sysdev_class a > > > valid-but-empty hotplug_ops but it seems simpler and more general to do it > > > in kobject_hotplug(). > > > > I tried that, but I found that parent "cpu" directory i.e > > /sys/devices/system/cpu itself was not getting created. Any clues? > > I don't see why the change to kobject_hotplug() would cause that directory > to not be created. > > With your patch and mine applied, /sys/devices/system/cpu is present and > populated on my test box. Hi Andrew, I am attaching the second one, just to make sure you and I have the same one. If this is different than what you are having let me know.
By the way I am testing on IA64 box, with 2.6.9-rc3 + just bk-driver-core.patch from your 2.6.9-rc3-mm2-broken-out.tar. I had to go for just above as I was seeing some out of memory messages on my IA64 box with complete rc3-mm2 patch.
thanks, Anil
---
linux-2.6.9-rc3-test-askeshav/drivers/base/cpu.c | 2 ++ 1 files changed, 2 insertions(+)
diff -puN drivers/base/cpu.c~test_akpm drivers/base/cpu.c --- linux-2.6.9-rc3-test/drivers/base/cpu.c~test_akpm 2004-10-04 23:45:45.304124223 -0700 +++ linux-2.6.9-rc3-test-askeshav/drivers/base/cpu.c 2004-10-05 10:54:08.725507956 -0700 @@ -9,9 +9,11 @@ #include <linux/topology.h> #include <linux/device.h> +struct kset_hotplug_ops cpu_kset_hotplug_ops; struct sysdev_class cpu_sysdev_class = { set_kset_name("cpu"), + .kset = { .hotplug_ops = &cpu_kset_hotplug_ops}, }; EXPORT_SYMBOL(cpu_sysdev_class); _ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |