Messages in this thread | | | Date | Mon, 4 Oct 2004 15:55:44 +0200 | From | Jens Axboe <> | Subject | Re: [bug] 2.6.8: CDROM_SEND_PACKET ioctls failing as non-root on ide scsi drives |
| |
On Mon, Oct 04 2004, Sean Neakums wrote: > Jens Axboe <axboe@suse.de> writes: > > > On Mon, Oct 04 2004, Sean Neakums wrote: > >> CDROM_SEND_PACKET calls down to sg_io, which calls verify_command, > >> which will not permit anyone but root to use any unrecognised > >> commands. GET CONFIGURATION does not seems to be one of those > >> recognised. This check for unrecognised commands is a fairly recent > >> addition, IIRC. > > > > 2.6.8 didn't have any command granularity, you must be root to issue any > > comand there. > > I was looking at 2.6.8.1 when I wrote the above, although it's > possible my eye skipped over something. > > verify_command certainly seems to do the check: > > http://lxr.linux.no/source/drivers/block/scsi_ioctl.c?v=2.6.8.1#L113 > > And it looks the same in the 2.6.8 tree I have here, too.
You are right, it was added before, my recollection of the events apparently isn't so good either. You are right in that GET_CONFIGURATION was added later, post 2.6.8 release.
> (Not trying to be an ass, just concerned about my reading comprehension.)
:-)
-- Jens Axboe
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |