lkml.org 
[lkml]   [2004]   [Oct]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 475] HP300 LANCE
    Jeff Garzik <jgarzik@pobox.com> wrote:
    >
    > Andrew Morton wrote:
    > > Jeff Garzik <jgarzik@pobox.com> wrote:
    > >
    > >>content looks OK, but patch appears to be whitespace-challenged...
    > >>
    > >
    > >
    > > It applies successfully.
    >
    > I'm talking about the _other_ type of "whitespace challenged", such as,
    >
    > - volatile struct lance_regs *ll;
    > + unsigned long base;
    >
    > and
    >
    > - void *va = dio_scodetoviraddr(scode);
    > + unsigned long pa = dio_scodetophysaddr(scode);
    > + unsigned long va = (pa + DIO_VIRADDRBASE);
    >
    > Reading through the patch you can see other one-space-off spots.
    >

    That's because the stoopid driver is using spaces instead of tabs all over
    the place. It comes out visually OK once the patch is applied. But it's a
    useful reminder of how much dreck we have in the tree.
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 14:07    [W:0.023 / U:32.892 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site