lkml.org 
[lkml]   [2004]   [Oct]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: net: generic netdev_ioaddr
    From
    Date
    Hi,

    Pekka Enberg <penberg@cs.helsinki.fi> writes:

    > Cops already exposes base address and irq as module parameters and yet
    > it calls netdev_boot_setup_check() to check "netdev=" so I assume
    > there's a reason for that. Perhaps something like the (untested) patch
    > below would make more sense?

    IMHO partially: base_addr etc should go from the core (to driver's
    local structs if needed). I think no general netdev-setup thing is
    needed, we have module parameters and library functions.

    No ioctl for such things is needed either.
    /sbin/ifconfig shouldn't mess with hardware data such as I/O address,
    IRQ etc. - it should be a configuration tool for software protocols,
    not for hardware (i.e. as /sbin/ip is).

    My opinion of course.
    --
    Krzysztof Halasa
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 14:07    [W:0.030 / U:0.008 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site