lkml.org 
[lkml]   [2004]   [Oct]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RFC][PATCH 0/3] net: generic netdev_ioaddr
    On Fri, Oct 29, 2004 at 01:04:04PM +0300, Pekka Enberg wrote:
    > Hi,
    >
    > This patch introduces a generic netdev_ioaddr and converts natsemi and
    > 8139too drivers to use it.
    >
    > With the recent __iomem annotations, the network drivers need to either
    > invent this wrapper (like natsemi has done) or duplicate the IO base
    > address in their private data (similar to 8139too). Therefore, lets
    > make netdev_ioaddr generic before it is all over the place.

    This casting around sounds like a bad idea. Either add another

    void __iomem *mmioaddr;

    member to struct net_device, or better move that completely into the
    driver-private structure which seems the better level of abstraction.

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 14:07    [W:0.029 / U:4.404 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site