Messages in this thread | | | Date | Fri, 29 Oct 2004 22:48:01 +0100 (BST) | From | Anton Altaparmakov <> | Subject | Re: RFC: Changes to fs/buffer.c? |
| |
On Fri, 29 Oct 2004, Linus Torvalds wrote: > On Fri, 29 Oct 2004, Andrew Morton wrote: > > Anton Altaparmakov <aia21@cam.ac.uk> wrote: > > > > > > Is it ok to export > > > create_buffers() and to make __set_page_buffers() static inline and move > > > it to include/linux/buffer.h? > > > > ho, hum - if you must ;) > > > > I'd be inclined to rename it to attach_page_buffers() or something though - > > create_buffers() is a bit generic-sounding. > > Also, I think we should at least start out limiting it to GPL-only usage. > Those page buffers are pretty intertwined with the VM usage, I'd hate to > see people think this is some kind of external interface..
Yes, sure. I will use the _GPL version for the symbol export. I only used the non-GPL-only form since create_empty_buffers() is simply exported and create_buffers() is kind of the same thing but does less...
Best regards,
Anton -- Anton Altaparmakov <aia21 at cam.ac.uk> (replace at with @) Unix Support, Computing Service, University of Cambridge, CB2 3QH, UK Linux NTFS maintainer / IRC: #ntfs on irc.freenode.net WWW: http://linux-ntfs.sf.net/ & http://www-stu.christs.cam.ac.uk/~aia21/ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |