lkml.org 
[lkml]   [2004]   [Oct]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: i386: use generic support for offsets.h
    On Fri, Oct 29, 2004 at 11:52:14AM +0200, Jan-Benedict Glaw wrote:
    > On Thu, 2004-10-28 21:02:21 +0200, Sam Ravnborg <sam@ravnborg.org>
    > wrote in message <20041028190221.GD9004@mars.ravnborg.org>:
    > > diff -Nru a/include/asm-i386/offsets.c b/include/asm-i386/offsets.c
    > > --- /dev/null Wed Dec 31 16:00:00 196900
    > > +++ b/include/asm-i386/offsets.c 2004-10-28 20:47:38 +02:00
    > > @@ -0,0 +1,66 @@
    >
    > To be honest, I don't really like to have .c files in the include
    > pathes... However, I don't know about a better idea (except maybe to
    > place this into ./linux/arch/$(ARCH)/lib/)...

    Having the source file in same directory as the result file is a
    pattern used all over the kernel. Moving the .c file to include/asm-xxx
    just made this true for offsets.h.
    In this process a renaming took place so the name of the source file
    and the result file match except for the extension.

    Some architectures had: asm_offsets.c => offsets.h
    A non-logical renaming.

    As for the idea of having source file located in a separate
    directory. It's not supported by kbuild today, and I'm reluctant
    to support it - since it usually triggers misuse.
    kbuild is about making the trivial stuff easy, but not about full
    flexibility. If we wanted full flexibility we would not have used
    so much effort to define a simple syntax.

    Sam
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 14:07    [W:0.021 / U:457.312 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site