Messages in this thread | | | Date | Fri, 29 Oct 2004 14:16:07 +0100 | From | Al Viro <> | Subject | Re: [RFC][PATCH 0/3] net: generic netdev_ioaddr |
| |
On Fri, Oct 29, 2004 at 01:04:04PM +0300, Pekka Enberg wrote: > Hi, > > This patch introduces a generic netdev_ioaddr and converts natsemi and > 8139too drivers to use it. > > With the recent __iomem annotations, the network drivers need to either > invent this wrapper (like natsemi has done) or duplicate the IO base > address in their private data (similar to 8139too). Therefore, lets > make netdev_ioaddr generic before it is all over the place.
NAK. ->base_addr casting is a Bad Idea(tm) and natsemi "solution" isn't (thanks for spotting that crap in natsemi, though; will fix...)
Note that there is no such thing as "generic IO base address" - it _is_ private and in the best case current ->base_addr is a scratch register probably used for something vaguely connected with some IO, but it's really up to driver... - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |