Messages in this thread | | | Subject | Re: ia64 failure with [PATCH] 8250: Let arch provide the list of leagacy ports | From | Benjamin Herrenschmidt <> | Date | Tue, 26 Oct 2004 08:20:04 +1000 |
| |
On Mon, 2004-10-25 at 18:08 -0400, James Bottomley wrote: > ia64 seems to rely on empty ports being registered. Without this, ia64 > crashes on boot with > > Removing wrong port: 0000000000000000 != a000000100781bd8
I send this patch to Linus already, though he may have missed it, I'll resend.
Ben.
> James > > ===== drivers/serial/8250.c 1.76 vs edited ===== > --- 1.76/drivers/serial/8250.c 2004-10-22 18:31:26 -05:00 > +++ edited/drivers/serial/8250.c 2004-10-25 16:59:22 -05:00 > @@ -2001,13 +2001,6 @@ > for (i = 0; i < UART_NR; i++) { > struct uart_8250_port *up = &serial8250_ports[i]; > > - /* Don't register "empty" ports, setting "ops" on them > - * makes the console driver "setup" routine to succeed, > - * which is wrong. --BenH. > - */ > - if (!up->port.iobase) > - continue; > - > up->port.line = i; > up->port.ops = &serial8250_pops; > up->port.dev = dev; -- Benjamin Herrenschmidt <benh@kernel.crashing.org>
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |