lkml.org 
[lkml]   [2004]   [Oct]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] pcmcia network drivers cleanup
[lkml added back in CC: list]

On Mon, Oct 25, 2004 at 05:21:21PM +0200, Dominik Brodowski wrote:

> I'd prefer if the irq_ module parameters weren't defined in one header with
> the nasty INTER_MODULE_PARAM(), but be kept per-module / per-device, i.e.
> the
>
> #define INT_MODULE_PARM(n, v) static int n = v; MODULE_PARM(n, "i")
>
> static int irq_list[4] = { -1 };
> MODULE_PARM(irq_list, "1-4i");
> INT_MODULE_PARM(irq_mask, 0xdeb8);
>
> block being replaced with
>
>
> static int irq_list[4] = { -1 };
> static int irq_mask irq_mask = 0xdeb8;
>
> module_parm(irq_mask, int, 0444};

Sure, it is probably saner, but INT_MODULE_PARM is used for quite a
few other parameters in each driver, and I didn't want to touch
all of them.

Would a patch modifying all occurences of INT_MODULE_PARM be accepted
by whoever maintains those drivers ?

Stelian.
--
Stelian Pop <stelian@popies.net>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:07    [W:1.274 / U:0.616 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site