Messages in this thread Patch in this message | | | Subject | [PATCH 4/28] VFS: Stat shouldn't stop expire | Date | Mon, 25 Oct 2004 10:40:30 -0400 | From | Mike Waychison <> |
| |
This patch fixes the problem where if you have a mountpoint that is going to expire, it fails to expire before somebody keeps stat(2)ing the root of it's filesystem. For example, consider the case where a user has his home directory automounted on /home/mikew. Some other user can keep the filesystem mounted forever by simply calling ls(1) in /home, because the stat action resets the marker on each call.
Signed-off-by: Mike Waychison <michael.waychison@sun.com> ---
namei.c | 11 ++++++++++- 1 files changed, 10 insertions(+), 1 deletion(-)
Index: linux-2.6.9-quilt/fs/namei.c =================================================================== --- linux-2.6.9-quilt.orig/fs/namei.c 2004-08-14 01:36:45.000000000 -0400 +++ linux-2.6.9-quilt/fs/namei.c 2004-10-22 17:17:34.762179488 -0400 @@ -275,7 +275,16 @@ int deny_write_access(struct file * file void path_release(struct nameidata *nd) { dput(nd->dentry); - mntput(nd->mnt); + /* + * In order to ensure that access to an automounted filesystems' + * root does not reset it's expire counter, we check to see if the path + * being released here is a mountpoint itself. If it is, then we call + * _mntput which leaves the expire counter alone. + */ + if (nd->mnt && nd->mnt->mnt_root == nd->dentry) + _mntput(nd->mnt); + else + mntput(nd->mnt); } /* - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |