lkml.org 
[lkml]   [2004]   [Oct]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: 2.6.9-mm1: pc_debug multiple definitions
    On Sat, Oct 23, 2004 at 11:41:52PM -0400, Luis R. Rodriguez wrote:
    > On Fri, Oct 22, 2004 at 03:39:29PM +0200, Adrian Bunk wrote:
    > >
    > > The following compile error comes from Linus' tree:
    > >
    > >
    > > <-- snip -->
    > >
    > > ...
    > > LD drivers/built-in.o
    > > drivers/pcmcia/built-in.o(.bss+0xf20): multiple definition of `pc_debug'
    > > drivers/net/built-in.o(.data+0x24ae0): first defined here
    > > make[1]: *** [drivers/built-in.o] Error 1
    > >
    > > <-- snip -->
    > >
    > >
    > > The pc_debug in drivers/pcmcia/ds.c was made non-static in Linus' tree,
    > > but the global definition of a global variable with such a generic name
    > > in drivers/net/wireless/prism54/islpci_mgt.c seems to be equally wrong.
    >
    > Great, anyone know why this change was done on ds.c ? The pc_debug on
    > prism54 comes from the original Intersil driver. It is used to for
    > debugging but we should move away from our current debugging mechanism
    > to netif_msg.
    >...

    pc_debug is a pretty generic name - it seems too generic in both files.

    In prism54, couldn't it be called prism54_pc_debug?

    > Luis

    cu
    Adrian

    --

    "Is there not promise of rain?" Ling Tan asked suddenly out
    of the darkness. There had been need of rain for many days.
    "Only a promise," Lao Er said.
    Pearl S. Buck - Dragon Seed

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 14:07    [W:4.171 / U:0.304 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site