lkml.org 
[lkml]   [2004]   [Oct]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: Make drivers/char/mem.c use remap_pfn_range()
On Fri, 22 Oct 2004, William Lee Irwin III wrote:
>> What I posted shifted the correct argument, though vma->vm_pgoff would
>> have been been better, as it shifted offset right by PAGE_SHIFT, where
>> offset could have overflowed. I have no idea what you're referring to
>> about shifting the wrong argument.

On Fri, Oct 22, 2004 at 08:09:07AM -0700, Linus Torvalds wrote:
> Ok, that patch just got lost.
> Quite as well, actually. The whole point of changing remap_page_range() to
> remap_pfn_range() is to give the full range of page frame numbers, and
> just shifting "offset" back down thus seems to be a bug to me. Otherwise
> we migth as well just have continued with the old code.

What I had intended to be the functional improvements were in the arch
code for pci_mmap_page_range(), but I would say the mem.c change beyond
my own changes is an improvement. All is well.


-- wli
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:07    [from the cache]
©2003-2011 Jasper Spaans. Advertise on this site