Messages in this thread | | | Subject | Re: [PATCH] kernel/timer.c: xtime lock missing | From | john stultz <> | Date | Thu, 21 Oct 2004 13:23:32 -0700 |
| |
On Thu, 2004-10-21 at 12:03, Benjamin LaHaise wrote: > Hello all, > > While looking at the time keeping code for related work, I came across > the following bug. During 2.5 development, the smptimers patch removed > a lock from update_times() that is actually needed over the xtime > update, since the second overflow is not an atomic operation. This > patch fixes that by doing a write_seqlock() over the course of the > update.
Errrr...
Looking at the comment above that function, the xtime_lock should already be held when executing that code. timer_interrupt() should be the function which grabs the lock and calls do_timer_interrupt() then do_timer() then update_times().
Or am I missing something?
thanks -john
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |