Messages in this thread | | | Date | Wed, 20 Oct 2004 09:10:45 +0100 | From | Russell King <> | Subject | Re: [PATCH] PCI fixes for 2.6.9 |
| |
On Tue, Oct 19, 2004 at 03:42:15PM -0700, Greg KH wrote: > ChangeSet 1.1997.37.29, 2004/10/06 12:50:32-07:00, kaneshige.kenji@jp.fujitsu.com > > [PATCH] PCI: warn of missing pci_disable_device() > > As mentioned in Documentaion/pci.txt, pci device driver should call > pci_disable_device() when it decides to stop using the device. But > there are some drivers that don't use pci_disable_device() so far.
No. This is wrong. There are some classes of devices, notably PCMCIA Cardbus drivers where buggy BIOS means this should _NOT_ be done.
There are BIOSen out there which refuse to suspend/resume if the Cardbus bridge is disabled.
It's not that the driver is buggy. It's that the driver has far more information than the PCI layer could ever have.
-- Russell King Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/ maintainer of: 2.6 PCMCIA - http://pcmcia.arm.linux.org.uk/ 2.6 Serial core - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |