lkml.org 
[lkml]   [2004]   [Oct]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    SubjectRe: [PATCH] Make netif_rx_ni preempt-safe
    From
    Date
    On Wed, 2004-10-20 at 15:14, Denis Vlasenko wrote:
    > On Wednesday 20 October 2004 19:47, Lee Revell wrote:
    > > On Wed, 2004-10-20 at 11:11, Denis Vlasenko wrote:
    > > > 0x57 == 87 bytes is too big for inline.
    > >
    > > Ugh. So the only fix is not to inline it?
    >
    > Yes.
    >
    > You can make it conditionally inline/non-inline
    > depending on SMP/preempt if you feel masochistic today :),
    > but last time I asked davem thought that it is over the top.

    I agree, not worth the trouble. This would actually depend only on
    PREEMPT and not SMP.

    OK, third try.

    Signed-Off-By: Lee Revell <rlrevell@joe-job.com>

    --- include/linux/netdevice.h~ 2004-10-20 15:51:00.000000000 -0400
    +++ include/linux/netdevice.h 2004-10-20 15:51:54.000000000 -0400
    @@ -694,11 +694,14 @@
    /* Post buffer to the network code from _non interrupt_ context.
    * see net/core/dev.c for netif_rx description.
    */
    -static inline int netif_rx_ni(struct sk_buff *skb)
    +static int netif_rx_ni(struct sk_buff *skb)
    {
    - int err = netif_rx(skb);
    + int err;
    + preempt_disable();
    + err = netif_rx(skb);
    if (softirq_pending(smp_processor_id()))
    do_softirq();
    + preempt_enable();
    return err;
    }


    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 14:07    [W:0.047 / U:0.176 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site