Messages in this thread Patch in this message | | | Subject | Re: [PATCH] Make netif_rx_ni preempt-safe | From | Lee Revell <> | Date | Tue, 19 Oct 2004 20:22:18 -0400 |
| |
On Tue, 2004-10-19 at 20:00, Herbert Xu wrote: > On Tue, Oct 19, 2004 at 07:55:33PM -0400, Lee Revell wrote: > > > > --- include/linux/netdevice.h~ 2004-10-19 18:50:18.000000000 -0400 > > +++ include/linux/netdevice.h 2004-10-19 18:51:01.000000000 -0400 > > @@ -696,9 +696,11 @@ > > */ > > static inline int netif_rx_ni(struct sk_buff *skb) > > { > > + preempt_disable(); > > int err = netif_rx(skb); > > This is broken on older compilers.
How about this:
Signed-Off-By: Lee Revell <rlrevell@joe-job.com>
--- include/linux/netdevice.h~ 2004-10-19 20:16:48.000000000 -0400 +++ include/linux/netdevice.h 2004-10-19 20:21:01.000000000 -0400 @@ -696,9 +696,12 @@ */ static inline int netif_rx_ni(struct sk_buff *skb) { - int err = netif_rx(skb); + int err; + preempt_disable(); + err = netif_rx(skb); if (softirq_pending(smp_processor_id())) do_softirq(); + preempt_enable(); return err; } - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |