lkml.org 
[lkml]   [2004]   [Oct]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [RFC][PATCH] inotify 0.14
    From
    Date
    On Sun, 2004-10-17 at 21:28, Stephen Rothwell wrote:
    > On Sun, 17 Oct 2004 19:52:09 -0400 Robert Love <rml@novell.com> wrote:
    > >
    > > It should make dnotify a configuration option, controlled via
    > > CONFIG_DNOTIFY.
    >
    > But you have removed the sysctl that allows enabling and disabling of
    > dnotify at run time. And you create setattr_mask_dnotify for which I can
    > find no caller. And make gratuitous changes to the current dnotify code.
    > (I point this last out as it just increases the size of the patch for no
    > purpose.)

    There may be bugs with how dnotify was made optional. I will accept a
    patch that fixes this :)

    It is debatable whether or not the inotify patch should carry this
    dnotify config patch as well. I don't see it being that large of a
    burden on maintaining or using the patch that includes the dnotify
    config changes.

    John
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 14:07    [W:0.045 / U:0.064 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site