lkml.org 
[lkml]   [2004]   [Oct]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] I/O space write barrier
    On Fri, Oct 15, 2004 at 05:38:09PM -0700, Jeremy Higdon wrote:
    > - (void) RD_REG_WORD(&reg->mailbox4); /* PCI posted write flush */
    > + /* Enforce mmio write ordering; see comment in qla1280_isp_cmd(). */
    > + mmiowb();

    I really don't think we want a comment by every mmiowb() explaining what
    it does. We needed one by the write flush because it had two potential
    meanings, and we didn't want people overoptimising it away. But mmiowb()
    is clear and unambiguous.

    --
    "Next the statesmen will invent cheap lies, putting the blame upon
    the nation that is attacked, and every man will be glad of those
    conscience-soothing falsities, and will diligently study them, and refuse
    to examine any refutations of them; and thus he will by and by convince
    himself that the war is just, and will thank God for the better sleep
    he enjoys after this process of grotesque self-deception." -- Mark Twain
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 14:07    [W:0.020 / U:59.872 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site