Messages in this thread | | | Date | Thu, 14 Oct 2004 20:29:26 +0100 | From | Matthew Wilcox <> | Subject | Re: [RESEND][PATCH 4/6] Add page becoming writable notification |
| |
On Thu, Oct 14, 2004 at 08:05:01PM +0100, David Howells wrote: > +static inline int do_wp_page_mk_pte_writable(struct mm_struct *mm, > + struct vm_area_struct *vma, > + unsigned long address, > + pte_t *page_table, > + struct page *old_page, > + pte_t pte)
I protest. There are at least 3 vowels and 2 non-acronyms in this function name. Also, 6 arguments is clearly too few. Can we not also pass a struct urb, an ethtool_wolinfo and a Scsi_Cmnd?
-- "Next the statesmen will invent cheap lies, putting the blame upon the nation that is attacked, and every man will be glad of those conscience-soothing falsities, and will diligently study them, and refuse to examine any refutations of them; and thus he will by and by convince himself that the war is just, and will thank God for the better sleep he enjoys after this process of grotesque self-deception." -- Mark Twain - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |