Messages in this thread | | | Date | Tue, 12 Oct 2004 09:38:52 -0700 | From | Hanna Linder <> | Subject | Re: [Kernel-janitors] [PATCH 2.6][9/12] pplus.c replace pci_find_device with pci_get_device |
| |
--On Saturday, October 09, 2004 10:02:01 AM -0700 Scott Feldman <sfeldma@pobox.com> wrote:
> On Thu, 2004-10-07 at 16:26, Hanna Linder wrote: >> - if ((dev = pci_find_device(PCI_VENDOR_ID_WINBOND, >> + if ((dev = pci_get_device(PCI_VENDOR_ID_WINBOND, >> PCI_DEVICE_ID_WINBOND_82C105, dev))) { >> /* >> * Disable LEGIRQ mode so PCI INTS are routed > > Missing cleanup at the bottom of func? > > if(dev) > pci_dev_put(dev); > > -scott
Hi Scott,
It doesnt need an explicit dev_put because the pci_dev * is used as the *from pointer in the pci_get_device call which will do the dev_put automaticaly.
Hanna
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |