Messages in this thread | | | Date | Tue, 12 Oct 2004 13:51:08 +0200 | From | Pavel Machek <> | Subject | Re: Totally broken PCI PM calls |
| |
Hi!
> > Well... it doesn't work on paul's laptop, but anyway, ok, let's go for > > the struct thing and forget about this for 2.6.9. > > PM hasn't worked for me on 2.6 with most hardware, about since > the "new PMcore" kicked in, so it's hard for me to judge progress > except at the level of unit tests. Where I see two steps forward, > one step back ... on a good day. > > The root cause of many of these problem is that there's > a confusion between system-wide sleep states and the > device-specific power states from which they're built. > They _should_ be using two distinct data types. Not one > integer/enum type ... especially not one int/enum type > that's got multiple conflicting "legacy" interpretations!
Actually I do not see what is so wrong with one enum type; with sparse we have typechecking, and if someone assigns value from one enum into another enum, he's clearly doing something wrong. Pavel -- People were complaining that M$ turns users into beta-testers... ...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl! - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |