Messages in this thread |  | | | Date | Mon, 11 Oct 2004 14:33:02 +0100 | | From | viro@parcelfa ... | | Subject | Re: [PATCH] Fix readw/writew warnings in drivers/net/wireless/hermes.h |
| |
On Mon, Oct 11, 2004 at 03:18:38PM +0200, Borislav Petkov wrote: > that in a great detail. As a result, the right thing to do here is, I think, to declare all addrs void __iomem*. > Which leaves a question: while compiling the following code fragment: > > <sound/pci/ymfpci/ymfpci_main.c> > static inline u8 snd_ymfpci_readb(ymfpci_t *chip, u32 offset) > { > return readb(chip->reg_area_virt + offset); > } > > gcc complains as so: > > sound/pci/ymfpci/ymfpci_main.c: In function `snd_ymfpci_readb': > sound/pci/ymfpci/ymfpci_main.c:57: warning: passing arg 1 of `readb' makes pointer from integer without a cast > > Do we have to cast here or use the new interface?
Make ->reg_area_virt void __iomem *. *However*, ALSA folks said that they have already done iomem annotations in their tree, so that's an area best left alone until they merge. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |