Messages in this thread | | | Date | Mon, 11 Oct 2004 22:31:37 +1000 | From | David Gibson <> | Subject | Re: [PATCH] Fix readw/writew warnings in drivers/net/wireless/hermes.h |
| |
On Mon, Oct 11, 2004 at 05:34:20PM +0530, Ricky lloyd wrote: > > Isn't the correct fix to declare iobase as (void __iomem *) ? > > > > Earlier today i had posted a patch which mainly fixes this same > problem with lotsa scsi > drivers and tulip drivers. I wondered the same "shouldnt all the addrs > be declared as > void __iomem* ??".
The trouble with that is that for some versions of the orinoco card, the iobase refers to a legacy ISA IO address, not a memory-mapped IO address (that's the inw()/outw() path in the macro). That needs an integer, rather than a pointer.
It's not clear to me which way around the cast is less ugly.
-- David Gibson | For every complex problem there is a david AT gibson.dropbear.id.au | solution which is simple, neat and | wrong. http://www.ozlabs.org/people/dgibson - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |