lkml.org 
[lkml]   [2004]   [Oct]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: video_usercopy() enforces change of VideoText IOCTLs since 2.6.8
> +#define VTXIOCGETINFO	_IOR  (0x81,  1, vtx_info_t)
> +#define VTXIOCCLRPAGE _IOW (0x81, 2, vtx_pagereq_t)
> +#define VTXIOCCLRFOUND _IOW (0x81, 3, vtx_pagereq_t)
> +#define VTXIOCPAGEREQ _IOW (0x81, 4, vtx_pagereq_t)
> +#define VTXIOCGETSTAT _IOW (0x81, 5, vtx_pagereq_t)
> +#define VTXIOCGETPAGE _IOW (0x81, 6, vtx_pagereq_t)
> +#define VTXIOCSTOPDAU _IOW (0x81, 7, vtx_pagereq_t)

Hmm, _IOW for VTXIOCGET* looks bogous, is that really correct?

Note that you often need RW for read/get ioctls because even these
often pass data to the driver as well (for example the vtx page number
you want query the status for). Please double-check that. Otherwise
the patch looks ok to me.

Gerd

--
return -ENOSIG;
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:06    [W:0.053 / U:0.416 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site