Messages in this thread | | | Date | Mon, 11 Oct 2004 10:16:25 -0400 (EDT) | From | Cal Peake <> | Subject | Re: [PATCH] Fix readw/writew warnings in drivers/net/wireless/hermes.h |
| |
On Mon, 11 Oct 2004 viro@parcelfarce.linux.theplanet.co.uk wrote:
> On Mon, Oct 11, 2004 at 08:23:35AM -0400, Cal Peake wrote: > > On Mon, 11 Oct 2004, Jan Dittmer wrote: > > > > > Cal Peake wrote: > > > > > > > inw((hw)->iobase + ( (off) << (hw)->reg_spacing )) : \ > > > > - readw((hw)->iobase + ( (off) << (hw)->reg_spacing ))) > > > > + readw((void __iomem *)(hw)->iobase + ( (off) << (hw)->reg_spacing ))) > > > > #define hermes_write_reg(hw, off, val) do { \ > > > > > > Isn't the correct fix to declare iobase as (void __iomem *) ? > > > > iobase is an unsigned long, declaring it as a void pointer is prolly not > > what we want to do here. The typecast seems proper. A lot of other drivers > > do this as well thus it must be proper ;-) > > Typecast is not a proper solution here. Folks, there are cleanups underway > for all that mess, but it's not _that_ simple. > > And adding casts to shut the warnings up is wrong in 99% of cases.
ok, I'm retarded. I'll shut up for the moment and get a clue :^)
-- Cal
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |