lkml.org 
[lkml]   [2004]   [Jan]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: Possibly wrong BIO usage in ide_multwrite
    On Mon, Jan 05 2004, Bartlomiej Zolnierkiewicz wrote:
    > On Monday 05 of January 2004 17:49, Jens Axboe wrote:
    > > On Mon, Jan 05 2004, Bartlomiej Zolnierkiewicz wrote:
    > > > > calling end_request with a null sector count, ide_end_request will then
    > > > > take hard_nr_sectors which will end the whole request even if only one
    > > > > bio was finished, huh? Am I missing something here?
    > > >
    > > > No, it is used mainly to fail requests.
    > > >
    > > > This hack should be later removed with care
    > > > (there is some strange comment about locking).
    > >
    > > IIRC, it's due to it not always being safe to inspect rq state outside
    > > of ide_lock. So that makes 0 a magic value that just means 'end the
    > > first chunk' for ide_end_request().
    >
    > Why/when it is not safe to do?

    You would need to read hwgroup->rq.

    --
    Jens Axboe

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 13:59    [W:0.020 / U:66.676 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site