![]() | |||||||||||||
Messages in this thread |
On Sat, 31 Jan 2004 02:38:51, Andrew Morton wrote: > Miquel van Smoorenburg <miquels@cistron.nl> wrote: > > But the XFS problem appears to be vn_revalidate which calls i_size_write() > > without holding i_sem: > > There's your bug. Okay. It seems that XFS uses its own locking with xfs_ilock() etc, so I am not sure if this should be fixed by using down(&inode->i_sem) or by using xfs_ilock(). Perhaps xfs_ilock() should also get the inode->i_sem semaphore in the XFS_ILOCK_EXCL case ? Also, there are one or two more places that call i_size_write() that should be looked at I guess. Ofcourse I'll test any patches you send me. Mike. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ | ||||||||||||
| Last update: 2005-03-22 13:00 [from the cache] ©2003-2008 | |||||||||||||