Messages in this thread |  | | | From | Bartlomiej Zolnierkiewicz <> | | Subject | Re: [PATCH] fix issues with loading PCI ide drivers as modules (linux 2.6.0) | | Date | Sun, 4 Jan 2004 04:52:17 +0100 |
| |
On Sunday 04 of January 2004 04:21, Davin McCall wrote: > However, there are still two genuine but easily solveable problems that I > can see: > > 1) unless "idex=base,ctl,irq" is used, the hwif->chipset is left as > "ide_unknown" (this means for that the hwif can get re-allocated in > setup-pci.c - ide_match_hwif() - and clobbered)
Hmm. What if hwif is freed by a driver?
> 2) if "idex=base,ctl,irq" IS used, the hwif structure will still get > clobbered when a PCI chipset module is loaded. > > What about this is a solution to these problems: > - set hwif->chipset to "ide_generic" instead of leaving it as > "ide_unknown" (ide-probe.c); - if ide_match_hwif() returns an already > allocated hwif, do not clobber it in ide_hwif_configure() (setup-pci.c)
This brakes "idex=base..." parameters for PCI chipsets. They shouldn't be needed in this case, but...
--bart
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |