Messages in this thread | | | Date | Tue, 27 Jan 2004 19:55:58 -0800 | From | "Randy.Dunlap" <> | Subject | Re: RFC: Trailing blanks in source files |
| |
On Tue, 27 Jan 2004 19:49:39 -0800 jw schultz <jw@pegasys.ws> wrote:
| On Tue, Jan 27, 2004 at 04:02:14PM -0800, Andrew Morton wrote: | > "Randy.Dunlap" <rddunlap@osdl.org> wrote: | > > | > > So please don't bother with just whitespace changes unless you | > > are going to cleanup a <driver | fs | module | etc> completely. | > | > And if you're going to do that, do the whitespace cleanup _first_, so the | > substantive changes to the driver/fs/module/etc can be sanely understood | > and reverted if necessary. | > | > I frequently sneakily remove all newly-added trailing whitespace from the | > patches people send me. In 15 years it'll all be gone. | | This would maybe warrant a bk option to remove trailing | whitespace from modified lines. Preferably with an | notification that it is happening so if for some reason you | do want trailing whitespace you could abort or override. | | A patch filter that removed trailing whitespace from + lines | could also be used.
AFAIK Andrew already uses a script to check for trailing spaces, and I do also. Yes, it could be modified to be a conversion filter, but it doesn't happen frequently, and when it does, I want to let the poster know about it, so I like to have the evidence handy. :)
-- ~Randy - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |