Messages in this thread Patch in this message | | | Date | Mon, 26 Jan 2004 16:54:21 +1100 | From | Rusty Russell <> | Subject | Re: Linux 2.4.25-pre7 |
| |
On Fri, 23 Jan 2004 16:58:24 -0200 (BRST) Marcelo Tosatti <marcelo.tosatti@cyclades.com> wrote: > Here goes -pre number 7 of 2.4.25 series.
Any chance of the forward-compatible module_param patch?
Name: 2.4 module_param Forward Compatibility Macros Author: Rusty Russell Status: Tested on 2.5.24-pre6 Version: 2.4
D: Simple uses of module_param() (implemented in 2.6) can be mapped D: onto the old MODULE_PARM macros. D: D: New code should use module_param() because: D: 1) Types are checked, D: 2) Existence of parameters are checked, D: 3) Customized types are possible [1] D: 4) Customized set/get routines are possible [1] D: 5) Parameters appear as boot params with prefix "<modname>." [1] D: 6) Optional viewing and control through sysfs [2] D: D: [1] Not for 2.4 compatibility macros D: [2] Not in 2.6.1 or 2.4, and only if third arg non-zero.
diff -urpN --exclude TAGS -X /home/rusty/devel/kernel/kernel-patches/current-dontdiff --minimal .25425-linux-2.4.25-pre6/include/linux/moduleparam.h .25425-linux-2.4.25-pre6.updated/include/linux/moduleparam.h --- .25425-linux-2.4.25-pre6/include/linux/moduleparam.h 1970-01-01 10:00:00.000000000 +1000 +++ .25425-linux-2.4.25-pre6.updated/include/linux/moduleparam.h 2004-01-21 14:24:41.000000000 +1100 @@ -0,0 +1,25 @@ +#ifndef _LINUX_MODULE_PARAMS_H +#define _LINUX_MODULE_PARAMS_H +/* Macros for (very simple) module parameter compatibility with 2.6. */ +#include <linux/module.h> + +/* type is byte, short, ushort, int, uint, long, ulong, bool. (2.6 + has more, but they are not supported). perm is permissions when + it appears in sysfs: 0 means doens't appear, 0444 means read-only + by everyone, 0644 means changable dynamically by root, etc. name + must be in scope (unlike MODULE_PARM). +*/ +#define module_param(name, type, perm) \ + static inline void *__check_existence_##name(void) { return &name; } \ + MODULE_PARM(name, _MODULE_PARM_STRING_ ## type) + +#define _MODULE_PARM_STRING_byte "b" +#define _MODULE_PARM_STRING_short "h" +#define _MODULE_PARM_STRING_ushort "h" +#define _MODULE_PARM_STRING_int "i" +#define _MODULE_PARM_STRING_uint "i" +#define _MODULE_PARM_STRING_long "l" +#define _MODULE_PARM_STRING_ulong "l" +#define _MODULE_PARM_STRING_bool "i" + +#endif /* _LINUX_MODULE_PARAM_TYPES_H */
-- there are those who do and those who hang on and you don't see too many doers quoting their contemporaries. -- Larry McVoy - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |