Messages in this thread | | | Date | Fri, 23 Jan 2004 06:54:10 +0000 | From | Dave Jones <> | Subject | Re: logic error in radeonfb. |
| |
On Fri, Jan 23, 2004 at 05:46:35PM +1100, Benjamin Herrenschmidt wrote: > On Fri, 2004-01-23 at 17:35, davej@redhat.com wrote: > > Looks like another instance of a ! in the wrong place. > > Ohh, and _oooold_ bug fixed a long time ago in 2.4. There may actually > be another occurence of this one elsewhere iirc. I'll check that.
Back then someone came up with a cool one-liner that grepped for suspicious if's with !'s, it seems no-one ever did the same for 2.6, as there were a few others (see seperate mails for patches).
> that this code is powermac specific anyway and that old radeonfb doesn't > work very well on a lot of powermacs, so it's not very urgent. The new > radeonfb which has that fixed for a long time will get in along with > the fbdev updates as soon as I'm finished cleaning them up.
Ok, If this is going to make your merge more difficult, feel free to ignore it.
Dave
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |