lkml.org 
[lkml]   [2004]   [Jan]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: Suspicious pointer usage in kobil_sct driver.
On Fri, Jan 23, 2004 at 06:35:25AM +0000, davej@redhat.com wrote:
> Greg, is this what's intended here?

Yes, your patch is correct. I'll go apply it, thanks.

greg k-h

> diff -urpN --exclude-from=/home/davej/.exclude bk-linus/drivers/usb/serial/kobil_sct.c linux-2.5/drivers/usb/serial/kobil_sct.c
> --- bk-linus/drivers/usb/serial/kobil_sct.c 2003-09-29 20:00:01.000000000 +0100
> +++ linux-2.5/drivers/usb/serial/kobil_sct.c 2004-01-23 05:06:40.000000000 +0000
> @@ -651,7 +651,7 @@ static int kobil_ioctl(struct usb_seria
> return 0;
>
> case TCSETS: // 0x5402
> - if (! &port->tty->termios) {
> + if (!(port->tty->termios)) {
> dbg("%s - port %d Error: port->tty->termios is NULL", __FUNCTION__, port->number);
> return -ENOTTY;
> }
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:00    [W:0.038 / U:0.044 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site